Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rds_option_group* modules and tests #1056

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented Sep 22, 2022

Depends-On: ansible/zuul-config#445

Migrate rds_option_group* modules and tests

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added integration tests/integration module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests labels Sep 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 6m 50s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 38s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 24s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 50s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 53s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 47s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-amazon.aws-1 SUCCESS in 8m 22s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 6m 39s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 3m 06s

@alinabuzachis alinabuzachis changed the title DNM Migrate rds_option_group* modules and tests Migrate rds_option_group* modules and tests Sep 22, 2022
@goneri goneri added the mergeit Merge the PR (SoftwareFactory) label Sep 22, 2022
@goneri
Copy link
Member

goneri commented Sep 23, 2022

regate

1 similar comment
@goneri
Copy link
Member

goneri commented Sep 23, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 4m 39s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 12m 13s

@softwarefactory-project-zuul
Copy link
Contributor

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@goneri
Copy link
Member

goneri commented Sep 23, 2022

regate

alinabuzachis and others added 9 commits September 22, 2022 21:45
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@142836b
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@017081c
…ent meta data (ansible-collections#1090)

For consistency - add empty dependencies file to targets with no current meta data

SUMMARY
For consistency - add empty dependencies file to targets with no current meta data
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/integration/targets
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@9638580
…ible-collections#1116)

Add missing `elements` option to type: list that did not specify

SUMMARY
Fixes ansible-collections#1114
ISSUE TYPE

Docs Pull Request

COMPONENT NAME

cloudfront_distribution
ecs_taskdefinition
elb_application_lb
rds_option_group

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c1d47dd
…sible-collections#1182)

Tagging fragment - Move simplest cases over to the docs fragment.

Depends-On: ansible-collections#844
SUMMARY
Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags.
ISSUE TYPE

Docs Pull Request
Feature Pull Request

COMPONENT NAME
changelogs/fragments/1182-tagging.yml
plugins/modules/aws_glue_job.py
plugins/modules/aws_msk_cluster.py
plugins/modules/aws_secret.py
plugins/modules/aws_step_functions_state_machine.py
plugins/modules/dynamodb_table.py
plugins/modules/ec2_eip.py
plugins/modules/ec2_transit_gateway_vpc_attachment.py
plugins/modules/ec2_vpc_peer.py
plugins/modules/elb_application_lb.py
plugins/modules/elb_network_lb.py
plugins/modules/iam_role.py
plugins/modules/iam_user.py
plugins/modules/networkfirewall.py
plugins/modules/networkfirewall_policy.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/rds_cluster.py
plugins/modules/rds_instance.py
plugins/modules/rds_instance_snapshot.py
plugins/modules/rds_option_group.py
plugins/modules/rds_subnet_group.py
plugins/modules/redshift.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@b11ffae
@goneri goneri force-pushed the promote_rds_option_group branch from 772f5aa to b512b9d Compare September 23, 2022 01:46
@goneri
Copy link
Member

goneri commented Sep 23, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 3m 30s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 07s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c4002cf into ansible-collections:main Sep 23, 2022
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Sep 23, 2022
Migrate rds_option_group* modules and tests

Depends-On: ansible-collections/amazon.aws#1056
Remove rds_option_group* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Migrate rds_option_group* modules and tests

Depends-On: ansible-collections#1056
Remove rds_option_group* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Migrate rds_option_group* modules and tests

Depends-On: ansible-collections#1056
Remove rds_option_group* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_module New module new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants