Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vol tests unstable #463

Closed
1 task done
tremble opened this issue Aug 12, 2021 · 4 comments
Closed
1 task done

ec2_vol tests unstable #463

tremble opened this issue Aug 12, 2021 · 4 comments
Labels
bug This issue/PR relates to a bug CI module module plugins plugin (any type)

Comments

@tremble
Copy link
Contributor

tremble commented Aug 12, 2021

Summary

The ec2_vol tests have been very unstable. The issue looks like it's related to idempotency.

https://dashboard.zuul.ansible.com/t/ansible/build/58185ada511a4e0799cfc3b97705d18b/log/job-output.txt

Issue Type

Bug Report

Component Name

ec2_vol

Ansible Version

CI

Collection Versions

CI

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

CI

OS / Environment

CI

Steps to Reproduce

Run CI tests multiple times

Expected Results

Tests consistently pass

Actual Results

Tests sporadically fail

https://dashboard.zuul.ansible.com/t/ansible/build/58185ada511a4e0799cfc3b97705d18b/log/job-output.txt

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@ansibullbot
Copy link

Files identified in the description:

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibullbot
Copy link

cc @jillr @lwade @s-hertel @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module needs_triage plugins plugin (any type) labels Aug 12, 2021
@markuman
Copy link
Member

markuman commented Aug 19, 2021 •
edited
Loading

The issue is, that the status is still "attaching", so this is failing https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_vol.py#L519 in the idempotent test task.

two possible fixes

  1. the module must wait until status becomes attached
  2. the "attach existing volume to an instance" task must retry until "vol_attach_result.volume.attachment_set[0].status == 'attached'"

When this is guaranteed, the idempotent task should also pass.

@tremble
Copy link
Contributor Author

tremble commented Aug 19, 2021

The better option would be to add an optional "wait" parameter to the module so that it waits for the attachment to finish before returning.

@goneri goneri added CI and removed needs_triage labels Aug 24, 2021
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this issue Sep 22, 2022
@alinabuzachis
rds_option_group (_info) new modules (ansible-collections#517)
813f733 
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@142836b
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@alinabuzachis
rds_option_group (_info) new modules (ansible-collections#517)
eafed74 
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
@alinabuzachis @abikouo
rds_option_group (_info) new modules (ansible-collections#517)
16d4b94 
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@alinabuzachis
rds_option_group (_info) new modules (ansible-collections#517)
142836b 
rds_option_group (_info) new modules

SUMMARY

Attempt to resurrect ansible/ansible#25290
Fixes: ansible-collections#463

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

rds_option_group
rds_option_group_info
Requires: mattclay/aws-terminator#144

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug CI module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goneri @tremble @markuman @ansibullbot