Migrate lambda* modules and tests #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
@alinabuzachis This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
needs_info
alinabuzachis
force-pushed
the
promote_lambda
branch
from
d6ace3b to
4ca7806
Compare
alinabuzachis
changed the title
gravesm
reviewed
Sep 19, 2022
|
recheck |
abikouo
approved these changes
Sep 21, 2022
gravesm
approved these changes
Sep 21, 2022
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
goneri
force-pushed
the
promote_lambda
branch
from
e46ff52 to
f20496c
Compare
|
regate |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@eb75681
The new tiny_prefix variable has recently been introduced. It's a 12 characters long string that is reused for the whole job. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4d1fa5a
lambda_info - use a paginator and AWSRetry SUMMARY Add paginator and AWSRetry to lambda_info. It seems to have a half-implemented manual pagination referring to parameters that don't exist. Just use the real pagination. ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@07e2522
Add tag query to lambda_info module SUMMARY This PR to add tags query into the lambda_info module. It is helpful to be able to query the Lambda function's tag list so we can integrate future actions. This PR also fix some missing parameter ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5235a3b
Remove deprecated "facts" aliases SUMMARY Modules named "facts.py" that do not return ansible_facts were renamed to "info.py" in 2.9. Remove these aliases now that the deprecation period is over. This PR should be included in 3.0.0 of the collection. ISSUE TYPE Bugfix Pull Request COMPONENT NAME *_facts.py Reviewed-by: Mark Chappell <None> Reviewed-by: Jill R <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@68aaa70
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes ansible-collections#830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@ab4bda2
Various integration test fixes SUMMARY Updates the version of Python used by lambda in the lambda_alias, lambda_policy and aws_secret integration tests Updates the version of NodeJS used by the lambda in the lamba integration tests Adds a retry to the s3_bucket_notification tests, permissions are sometimes a little slow to update Cleans up Snapshots from rds_instance integration tests Disables broken WAFv2 integration test (ansible-collections#985) Fixes: ansible-collections#976 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_secret lambda lambda_alias lambda_policy rds_policy s3_bucket_notification wafv2 ADDITIONAL INFORMATION Amazon appear to have dropped support for creating Python2.7 lambdas: botocore.errorfactory.InvalidParameterValueException: An error occurred (InvalidParameterValueException) when calling the CreateFunction operation: The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions. Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c5e4640
Integration test dependency cleanup SUMMARY remove dependencies on setup_remote_tmp_dir where it's not used (often just copy & paste from another test) remove setup_ec2 (no main.yml means it's not doing anything) remove prepare_tests (empty main.yml means it's not doing anything) ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did". Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@dd12046
lambda - update RETURN docs with more information on return data SUMMARY Give more information on what the return dictionaries contain ISSUE TYPE Docs Pull Request COMPONENT NAME lambda Reviewed-by: Mark Woolley <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@77e3162
lambda - fix check mode on creation Depends-On: ansible-collections#1116 SUMMARY When adding integration tests for check mode runs, creating a lambda function failed on check mode with the message "Unable to get function information after creating". Added parameter kms_key_arn - testing in integration tests appears difficult as I think we'd need to create an IAM policy to allow for adding kms_key, which would render these tests as unsupported. Added extra waiter for function_update in execute_lambda to resolve occasional integration test failure. Fixes ansible-collections#1111 ISSUE TYPE Feature Pull Request Bugfix Pull Request COMPONENT NAME lambda Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@0bde6bb
…ctions#1115) execute_lambda - fix check mode and update RETURN docs Depends-On: ansible-collections#1116 SUMMARY check_mode fix update RETURN docs to match what is actually being returned require one of name, function_arn ISSUE TYPE Bugfix Pull Request COMPONENT NAME execute_lambda ADDITIONAL INFORMATION I noticed some modules in community.aws will return data directly, and others will return data nested in a dict. Example: let iam_group be the module, retrieving a key called group_arn, and registering the response as response. Some modules you would need to query result.iam_group.group_arn, meanwhile in others, you can result.group_arn (where iam_group is assumed, since its the name of the module). Do we have a preference for either method? Should we come to some sort of collection-wide consensus on which to use moving forward? Reviewed-by: Sloane Hertel <None> Reviewed-by: Markus Bergholz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@f2ad637
…collections#1152) lambda_info - refactor to fix bug when querying all lambdas Depends-On: ansible/ansible-zuul-jobs#1558 SUMMARY Fix bug that forces query: config when getting info for all lambdas. Refactored to return the expected info Add extra cleanup at end of tests Fixes ansible-collections#1151 ISSUE TYPE Bugfix Pull Request COMPONENT NAME lambda_info ADDITIONAL INFORMATION This module also currently returns a dict of dicts (as opposed to a list of dicts), but I wanted to keep the scope of this PR to fixing the bug. Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@0c76aed
lambda - Add support for purge_tags
SUMMARY
Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
COMPONENT NAME
lambda
ADDITIONAL INFORMATION
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@982580a
rename execute_lambda SUMMARY In line with the naming guidelines, rename execute_lambda to lambda_execute ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/execute_lambda.py plugins/modules/lambda_execute.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b113be5
…le-collections#1239) lambda_info - Return list of dicts as opposed to dict of dicts SUMMARY Previously returned function, which was a dict of dicts. Deprecated function in replace of lambda_info which is a list of dicts. Return config details regardless of query (function_arn, function_name, etc) ISSUE TYPE Feature Pull Request COMPONENT NAME lambda_info Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@32ade3b
…lections#1377) lambda - Add support for setting supported architectures SUMMARY fixes: ansible-collections#744 Adds support for setting supported architectures - needs botocore 1.21.51 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/lambda.py plugins/modules/lambda_info.py ADDITIONAL INFORMATION Return docs changes have no version_added because they only depend the botocore version rather than the module version. (1.0.0 would return the values if botocore was new enough) Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@8be6062
Minor linting fixups - 2022-08-12 SUMMARY Various linting and unit test fixups unused variables overly broad Exception catching (highlighted some broken tests) removes direct use of unittest in favour of pytest (see also ansible-collections#961) cleans up skipping of tests when botocore/boto3 aren't installed passes error message from VPNConnectionException into its super to make testing easier, should never be directly exposed to the user Removes tests for 3 modules which now have integration tests, they're either recording based (fragile)or test things which are separately tested in the integration tests. lambda s3_bucket_notifications route53_zone ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_vpc_vpn.py tests/unit ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@8b4afa9
adjust booleans: use true/false Depends-On: ansible-collections#1423 SUMMARY ansible-community/community-topics#116 ISSUE TYPE Docs Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cb9716e
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
goneri
force-pushed
the
promote_lambda
branch
from
f20496c to
2dc1919
Compare
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 34s |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Sep 28, 2022
Migrate lambda* modules and tests Depends-On: ansible-collections/amazon.aws#1030 Remove lambda* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate lambda* modules and tests Depends-On: ansible-collections#1030 Remove lambda* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate lambda* modules and tests Depends-On: ansible-collections#1030 Remove lambda* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/zuul-config#443
Migrate lambda* modules and tests