Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pytest-forked to test requirements #1202

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 26, 2022

SUMMARY

ansible-test is using pytest --forked we need the sub-module installed

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test-requirements.txt

ADDITIONAL INFORMATION

See also: ansible/ansible#76679

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_triage small_patch Hopefully easy to review labels Oct 26, 2022
@tremble tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch labels Oct 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 44s
✔️ build-ansible-collection SUCCESS in 4m 58s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 59s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 02s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 03s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 56s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 24s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 22s
✔️ cloud-tox-py3 SUCCESS in 3m 05s

@tremble tremble marked this pull request as ready for review October 26, 2022 08:16
@tremble tremble requested a review from alinabuzachis October 26, 2022 08:16
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 26, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 31s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 52s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 59s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 57s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 16s
✔️ cloud-tox-py3 SUCCESS in 3m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b27ac1d into ansible-collections:main Oct 26, 2022
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/b27ac1dcb36ac8e65cad3f7a9cb462bb97a0310c/pr-1202

Backported as #1203

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
add pytest-forked to test requirements

SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit b27ac1d)
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/b27ac1dcb36ac8e65cad3f7a9cb462bb97a0310c/pr-1202

Backported as #1204

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
add pytest-forked to test requirements

SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit b27ac1d)
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/b27ac1dcb36ac8e65cad3f7a9cb462bb97a0310c/pr-1202

Backported as #1205

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
add pytest-forked to test requirements

SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit b27ac1d)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 26, 2022
[PR #1202/b27ac1dc backport][stable-5] add pytest-forked to test requirements

This is a backport of PR #1202 as merged into main (b27ac1d).
SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 26, 2022
[PR #1202/b27ac1dc backport][stable-4] add pytest-forked to test requirements

This is a backport of PR #1202 as merged into main (b27ac1d).
SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 26, 2022
[PR #1202/b27ac1dc backport][stable-3] add pytest-forked to test requirements

This is a backport of PR #1202 as merged into main (b27ac1d).
SUMMARY
ansible-test is using pytest --forked we need the sub-module installed
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
test-requirements.txt
ADDITIONAL INFORMATION
See also: ansible/ansible#76679

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 27, 2022
[PR #1199/5fe427c6 backport][stable-5] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 27, 2022
[PR #1199/5fe427c6 backport][stable-4] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
markuman pushed a commit to markuman/amazon.aws that referenced this pull request Nov 14, 2022
lambda - Add support for purge_tags

SUMMARY

Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
lambda
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@982580a
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 5, 2023
[PR #1199/5fe427c6 backport][stable-3] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
Depends-On: ansible/ansible-zuul-jobs#1734
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the tests/pytest-forked branch February 15, 2023 09:06
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda - Add support for purge_tags

SUMMARY

Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
lambda
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
lambda - Add support for purge_tags

SUMMARY

Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
lambda
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
lambda - Add support for purge_tags

SUMMARY

Use tagging fragment
Add purge_tags
Add resource_tags alias to tags
fix bug with returned tag names getting snake cased
fix bug where the lambda module was modifying tags in check mode
Tweak tagging to require an explicit tags: {} to remove tags

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request

COMPONENT NAME
lambda
ADDITIONAL INFORMATION

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) needs_triage small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants