Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting new tag added in TagsDialog #8766

Merged
merged 3 commits into from
Jun 27, 2021

Conversation

TarekkMA
Copy link
Contributor

@TarekkMA TarekkMA commented May 3, 2021

Pull Request template

This PR is based on #8763

Purpose / Description

Fixes

Fixes #8764

Approach

sorting after the tag is checked

How Has This Been Tested?

Emulator

Checklist

  • You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • Your code follows the style of the project (e.g. never omit braces in if statements)
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@TarekkMA TarekkMA changed the title Fix sorting new tag fix: sorting new tag added in TagsDialog May 3, 2021
@TarekkMA TarekkMA force-pushed the fix-sorting-new-tag branch 3 times, most recently from efe2b43 to d3bb04c Compare May 3, 2021 21:08
@TarekkMA
Copy link
Contributor Author

TarekkMA commented May 3, 2021

Added a test to check if the tag is sorted correctly when added

@TarekkMA TarekkMA force-pushed the fix-sorting-new-tag branch from d3bb04c to 8957534 Compare May 4, 2021 16:55
@TarekkMA TarekkMA force-pushed the fix-sorting-new-tag branch from 8957534 to 5b93653 Compare May 4, 2021 20:07
@TarekkMA TarekkMA force-pushed the fix-sorting-new-tag branch from 5b93653 to 66f3dee Compare May 4, 2021 20:11
TarekkMA added 2 commits May 4, 2021 22:22
+ test for new tag
+ test for existing tag
@TarekkMA TarekkMA force-pushed the fix-sorting-new-tag branch from 66f3dee to 2b7ce81 Compare May 4, 2021 20:24
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! LGTM - thanks @TarekkMA

@mikehardy mikehardy merged commit 624567b into ankidroid:master Jun 27, 2021
@mikehardy mikehardy added this to the 2.16 release milestone Jun 27, 2021
@mikehardy
Copy link
Member

Hi there!

Apologies for the delay, and if you're already submitted something to OpenCollective for PRs merged in June 2021 PRs merged, you may feel free to ignore this and it will be processed shortly

Just a friendly notice that we try to process OpenCollective payments monthly - it's time for June 2021 submissions

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

(I only post one comment per person to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged in May)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] added tag in TagsDialog doesn't get sorted in the list correctly
2 participants