-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sorting new tag added in TagsDialog
#8766
Conversation
efe2b43
to
d3bb04c
Compare
Added a test to check if the tag is sorted correctly when added |
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.java
Outdated
Show resolved
Hide resolved
d3bb04c
to
8957534
Compare
8957534
to
5b93653
Compare
5b93653
to
66f3dee
Compare
+ test for new tag + test for existing tag
66f3dee
to
2b7ce81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! LGTM - thanks @TarekkMA
Hi there! Apologies for the delay, and if you're already submitted something to OpenCollective for PRs merged in June 2021 PRs merged, you may feel free to ignore this and it will be processed shortly Just a friendly notice that we try to process OpenCollective payments monthly - it's time for June 2021 submissions If you are interested in compensation for this work, the process with details is here: (I only post one comment per person to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged in May) Thanks! |
Pull Request template
This PR is based on #8763
Purpose / Description
Fixes
Fixes #8764
Approach
sorting after the tag is checked
How Has This Been Tested?
Emulator
Checklist
if
statements)