fix: added tag doesn't reflect in adapter

[TarekkMA]

Pull Request template

Purpose / Description

I have reverted to the old way of handling mFilteredList.

Fixes

Fixes #8762

Approach

mFilteredList will be only set when there is a search filter active, otherwise, it's null and the adapter will use the original full list.

How Has This Been Tested?

Emulator

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[mikehardy]

Is there a way to do a test here? Seems like robolectric should be able to drive the activity enough that you can check it and verify the regression + the fix? I'll admit, these kinds of tests where it deals with a few UI elements at once are a bit involved, but the fragment stuff is so new it would be nice to have more testing exercising it

[TarekkMA]

Is there a way to do a test here? Seems like robolectric should be able to drive the activity enough that you can check it and verify the regression + the fix? I'll admit, these kinds of tests where it deals with a few UI elements at once are a bit involved, but the fragment stuff is so new it would be nice to have more testing exercising it

I will try, the issue I think is the involvement of RecyclerView. will see if I can use robolectric to deal with it

[TarekkMA]

@mikehardy done.

I had to add these lines to make sure the adapter is updated to the new data.

            recycler.measure(0, 0);
            recycler.layout(0, 0, 100, 1000);

[mikehardy]

Cool, lgtm