Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Regression added tag in TagsDialog don't appear in RecyclerView #8762

Closed
TarekkMA opened this issue May 3, 2021 · 1 comment · Fixed by #8763
Closed

[Bug] Regression added tag in TagsDialog don't appear in RecyclerView #8762

TarekkMA opened this issue May 3, 2021 · 1 comment · Fixed by #8763
Milestone
2.15 release

Comments

@TarekkMA
Copy link
Contributor

TarekkMA commented May 3, 2021

My PR #8322 Added this bug since the main data structure backing the recycler view mFilteredList is a copy of all tags in TagsList the changes in TagsList don't reflect to the recyclerview

Reproduction Steps
  1. Open TagsDialog
  2. Click '+' icon
  3. Add tag
Expected Result

the new tag is visible in the list

Actual Result

the new tag isn't visible in the list
@TarekkMA
Copy link
Contributor Author

TarekkMA commented May 3, 2021

I'm working on solving it

@TarekkMA TarekkMA mentioned this issue May 3, 2021
Merged
7 tasks
@mikehardy mikehardy added this to the 2.15 release milestone May 3, 2021
@TarekkMA TarekkMA mentioned this issue May 3, 2021
Closed
TarekkMA added a commit to TarekkMA/Anki-Android that referenced this issue May 3, 2021
@TarekkMA
test: regression ankidroid#8762
dbe54f8
TarekkMA added a commit to TarekkMA/Anki-Android that referenced this issue May 3, 2021
@TarekkMA
test: regression ankidroid#8762
2bf512f
mikehardy pushed a commit that referenced this issue May 3, 2021
@TarekkMA @mikehardy
test: regression #8762
388b8e7
mikehardy pushed a commit to mikehardy/Anki-Android that referenced this issue May 14, 2021
@TarekkMA @mikehardy
test: regression ankidroid#8762
932cb7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15 release
Development

Successfully merging a pull request may close this issue.

fix: added tag doesn't reflect in adapter TarekkMA/Anki-Android
2 participants
@mikehardy @TarekkMA