test: tag sorting

ankidroid · May 3, 2021 · d3bb04c · d3bb04c
1 parent 5d8fe7a
commit d3bb04c
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/tags/TagsDialogTest.java b/AnkiDroid/src/test/java/com/ichi2/anki/dialogs/tags/TagsDialogTest.java
@@ -47,6 +47,8 @@
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.core.IsNull.notNullValue;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNotEquals;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.times;
@@ -157,8 +159,9 @@ public void testTagsDialogCustomStudyOptionFragmentAPI() {
 
 
     // regression test #8762
+    // test for #8763
     @Test
-    public void test_AddNewTag_shouldBeVisibleInRecyclerView() {
+    public void test_AddNewTag_shouldBeVisibleInRecyclerView_andSortedCorrectly() {
         final DialogType type = DialogType.ADD_TAG;
         final List<String> allTags = Arrays.asList("a", "b", "d", "e");
         final List<String> checkedTags = Arrays.asList("a", "b");
@@ -181,7 +184,7 @@ public void test_AddNewTag_shouldBeVisibleInRecyclerView() {
             final View body = dialog.getCustomView();
             RecyclerView recycler = body.findViewById(R.id.tags_dialog_tags_list);
 
-            final String NEW_TAG = "c";
+            final String NEW_TAG = "zzzz";
 
             f.addTag(NEW_TAG);
 
@@ -190,11 +193,14 @@ public void test_AddNewTag_shouldBeVisibleInRecyclerView() {
             recycler.measure(0, 0);
             recycler.layout(0, 0, 100, 1000);
 
-            TagsArrayAdapter.ViewHolder vh = (TagsArrayAdapter.ViewHolder) recycler.findViewHolderForAdapterPosition(2);
-            CheckedTextView itemView = (CheckedTextView) vh.itemView;
+            CheckedTextView lastItem = (CheckedTextView) ((TagsArrayAdapter.ViewHolder) recycler.findViewHolderForAdapterPosition(4)).itemView;
+            CheckedTextView newTagItemItem = (CheckedTextView) ((TagsArrayAdapter.ViewHolder) recycler.findViewHolderForAdapterPosition(2)).itemView;
 
-            assertEquals(NEW_TAG, itemView.getText());
-            assertTrue(itemView.isChecked());
+            assertEquals(NEW_TAG, newTagItemItem.getText());
+            assertTrue(newTagItemItem.isChecked());
+
+            assertNotEquals(NEW_TAG, lastItem.getText());
+            assertFalse(lastItem.isChecked());
         });
     }