Create 10.x branch for node < 6 users (NOT LTS) #179
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
| }, | ||
| "engines": { | ||
| "node": ">=4", | ||
| "npm": ">=3" |
There was a problem hiding this comment.
@cnishina is this a breaking change? I can just remove this bit if it is
|
Should we include these? These were written for ES6 promises:
|
|
I don't see a good reason not too? They run in node 4.7.0 at least |
|
Commits removed |
…he level of output (angular#156) I added the `--quiet` flag for cases like: `webdriver-manager start --detach; ./tests.sh; webdriver-manager shutdown` where currently the selenium server output will get mixed in with other output. I also added the `--verbose` flag for `webdriver-manager update` in case you *really* wanted to see all the output which gets eaten by using `--android-accept-licenses`.
… already off (angular#162) When scripting, you might want to defensively run a `shutdown` command. If the shutdown fails because the server is already off, you don't care. If it fails for another reason, you do care. So I made trying to shutdown a server which is already off just a warning. I added a flag in case you want the old behavior though.
The default was x86-64, but x86 cannot be emulated on ARM. This makes more sense
…ling (angular#161) Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be booted up and ready to instance chrome. While I was doing that I moved some stuff into `lib/utils.ts` since I felt like too much of `lib/cmds/start.ts` was being devoted to this one feature. Also closes angular#166
Travis only runs a subset of tests via `npm run test_travis`, but `npm test` runs a full suite. See angular#165 for details on why travis cannot run all tests.
…master for circle-ci debugging
- version 10.2.9 unpublished from npm and tag removed from github due to breaking change with requiring node 6 LTS closes angular#170
…ular#175) - Recently a new version of the chrome-driver has been released (v2.26). It includes a lot of fixes for the latest Chrome version. https://sites.google.com/a/chromium.org/chromedriver/downloads
…ngular#173) - clang formatting closes angular#147
… >= 1.6 This should have been done a while ago, but I guess I didn't notice. This is a non-issue for master, since we require node >= 6 there.
|
Ok, this time for real, no es6 promises |
This PR does not indicate any LTS plans for node < 6
We've had a few useful features come in since we broke off from node < 6, and it would probably make our lives easier to do another 10.x release with those features merged in. This PR cherry-picks all the commits except for c16bf90, and also adds one new commit entitled
chore(npm version warnings): npm needs to be >= 3.0 to install appium >= 1.6(which needs review). I have verified thatnpm testworks on ubuntu with [email protected] and [email protected].Our CI isn't configured for 10.x releases so ignore that. Same with the CLA