fix(start): wait for emulated android to really be ready before signaling #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
force-pushed
the
started_api
branch
8 times, most recently
from
4590b30 to
f3bda88
Compare
|
Blocked on #163 |
sjelin
force-pushed
the
started_api
branch
3 times, most recently
from
9846f02 to
4bbae01
Compare
|
Unblocked! |
Merged
heathkit
reviewed
Nov 28, 2016
| error.message + ')'); | ||
| }) | ||
| .then<string>(() => { | ||
| logger.info('Waiting on for ' + avdName + ' to be ready to launch chrome'); |
heathkit
reviewed
Nov 28, 2016
| @@ -422,6 +438,7 @@ function sendStartedSignal(signal: string, viaIPC: boolean) { | |||
| logger.warn('No IPC channel, sending signal via stdout'); | |||
| } | |||
| } | |||
| console.log(signal); | |||
There was a problem hiding this comment.
Is this supposed to be here?
There was a problem hiding this comment.
Yes. The signal goes to stdout if it isn't send by and IPC channel. This functionality was accidentally removed in 1f9713a, and I fixed it while debugging this PR. I could make a issue to document the bug/fix if you'd like
There was a problem hiding this comment.
Ah, I see. Yeah, it'd be nice to have a short comment explaining that.
|
lgtm, minor nits |
…ling Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be booted up and ready to instance chrome. While I was doing that I moved some stuff into `lib/utils.ts` since I felt like too much of `lib/cmds/start.ts` was being devoted to this one feature. Also closes angular#166
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 16, 2016
…ling (angular#161) Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be booted up and ready to instance chrome. While I was doing that I moved some stuff into `lib/utils.ts` since I felt like too much of `lib/cmds/start.ts` was being devoted to this one feature. Also closes angular#166
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
…ling (angular#161) Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be booted up and ready to instance chrome. While I was doing that I moved some stuff into `lib/utils.ts` since I felt like too much of `lib/cmds/start.ts` was being devoted to this one feature. Also closes angular#166
sjelin
added a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
…ling (angular#161) Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be booted up and ready to instance chrome. While I was doing that I moved some stuff into `lib/utils.ts` since I felt like too much of `lib/cmds/start.ts` was being devoted to this one feature. Also closes angular#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were just waiting for the emulator to be running, rather than waiting for the OS to be
booted up and ready to instance chrome.
While I was doing that I moved some stuff into
lib/utils.tssince I felt like too much oflib/cmds/start.tswas being devoted to this one feature.Additionally,
--started-signifierwasn't sending anything to the console, so I fixed that too (see #166)