fix(iedriver): if downloading x64, use x64 version on start command #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
force-pushed
the
fix_iedriver
branch
3 times, most recently
from
3200136 to
965eeb4
Compare
heathkit
suggested changes
Dec 13, 2016
| binaries[IEDriver.id].arch = 'Win32'; | ||
| } | ||
| args.push( | ||
| '-Dwebdriver.ie.driver=' + | ||
| path.resolve(outputDir, binaries[IEDriver.id].executableFilename(osType))); | ||
| } | ||
| if (options[Opt.EDGE]) { | ||
| if (options[Opt.EDGE] != null && options[Opt.EDGE].getString()) { |
There was a problem hiding this comment.
This could just be if (options[Opt.EDGE] && options[Opt.EDGE].getString())
cnishina
force-pushed
the
fix_iedriver
branch
from
965eeb4 to
31b572f
Compare
- clang formatting closes angular#147
cnishina
force-pushed
the
fix_iedriver
branch
from
31b572f to
4edf542
Compare
heathkit
approved these changes
Dec 14, 2016
sjelin
pushed a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 16, 2016
…ngular#173) - clang formatting closes angular#147
sjelin
pushed a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 16, 2016
…ngular#173) - clang formatting closes angular#147
sjelin
pushed a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
…ngular#173) - clang formatting closes angular#147
sjelin
pushed a commit
to sjelin/webdriver-manager
that referenced
this pull request
Dec 20, 2016
…ngular#173) - clang formatting closes angular#147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #147