Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iedriver): if downloading x64, use x64 version on start command #173

Merged
merged 1 commit into from
Dec 14, 2016
Merged

fix(iedriver): if downloading x64, use x64 version on start command #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/cmds/start.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ function start(options: Options) {
// https://bugs.openjdk.java.net/browse/JDK-6202721
args.push('-Djava.security.egd=file:///dev/./urandom');
}

if (options[Opt.LOGGING].getString()) {
if (path.isAbsolute(options[Opt.LOGGING].getString())) {
loggingFile = options[Opt.LOGGING].getString();
Expand All @@ -154,14 +153,14 @@ function start(options: Options) {
path.resolve(outputDir, binaries[GeckoDriver.id].executableFilename(osType)));
}
if (downloadedBinaries[IEDriver.id] != null) {
if (options[Opt.IE32]) {
if (options[Opt.IE32].getBoolean()) {
binaries[IEDriver.id].arch = 'Win32';
}
args.push(
'-Dwebdriver.ie.driver=' +
path.resolve(outputDir, binaries[IEDriver.id].executableFilename(osType)));
}
if (options[Opt.EDGE]) {
if (options[Opt.EDGE] && options[Opt.EDGE].getString()) {
// validate that the file exists prior to adding it to args
try {
let edgeFile = options[Opt.EDGE].getString();
Expand Down