update(input): remove align input binding #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `align` input property for the `md-input-container` is not doing anything special and can be easily replaced with normal CSS from the user. BREAKING CHANGE: The `align` input from the `<md-input-container>` component has been removed. Developers instead should use plain CSS to archive the same (using `text-align: end` for example) Fixes angular#5140
googlebot
added
the
cla: yes
jelbourn
added
merge: caretaker note
|
Caretaker note: need to check for uses inside of Google before presubmit |
|
Note: couldn't find any Google uses. |
kara
removed
the
merge: caretaker note
|
I think the .demo-text-align-end class breaks the .mat-input-underline text-align, which causes the underline to align to the end instead to left, see instances below taken from input demo page:
Please check. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aligninput property for themd-input-containeris not doing anything special and can be easily replaced with normal CSS from the user.BREAKING CHANGE: The
aligninput from the<md-input-container>component has been removed. Developers instead should use plain CSS to archive the same (usingtext-align: endfor example)Fixes #5140