Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(input): remove align input binding #5141

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

devversion
Copy link
Member

  • The align input property for the md-input-container is not doing anything special and can be easily replaced with normal CSS from the user.

BREAKING CHANGE: The align input from the <md-input-container> component has been removed. Developers instead should use plain CSS to archive the same (using text-align: end for example)

Fixes #5140

* The `align` input property for the `md-input-container` is not doing anything special and can be easily replaced with normal CSS from the user.

BREAKING CHANGE: The `align` input from the `<md-input-container>` component has been removed. Developers instead should use plain CSS to archive the same (using `text-align: end` for example)

Fixes angular#5140
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 15, 2017
@jelbourn
Copy link
Member

Caretaker note: need to check for uses inside of Google before presubmit

@kara
Copy link
Contributor

kara commented Jun 16, 2017

Note: couldn't find any Google uses.

@kara kara removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 16, 2017
@kara kara merged commit 0aaeb69 into angular:master Jun 16, 2017
@devversion devversion deleted the update/remove-input-align-binding branch June 16, 2017 22:54
@BaimosTechnologies
Copy link

I think the .demo-text-align-end class breaks the .mat-input-underline text-align, which causes the underline to align to the end instead to left, see instances below taken from input demo page:

screen shot 2017-06-19 at 11 36 06
screen shot 2017-06-19 at 11 37 02
screen shot 2017-06-19 at 11 37 21

Please check.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove align input from MdInputContainer
6 participants