Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input: align-end demo is broken #5332

Closed
mmalerba opened this issue Jun 23, 2017 · 4 comments
Closed

input: align-end demo is broken #5332

mmalerba opened this issue Jun 23, 2017 · 4 comments
Assignees
@devversion
Labels
area: material/input needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions

Comments

@mmalerba
Copy link
Contributor

The align-end demo for the input looks strange now, following #5141 it seems like the placeholder is right-aligned, but the input content is not. The placeholder animation is also strange, it seems to get clipped.

FWIW I'm not sure if the old behavior was exactly right either? previously the input content was right-aligned while the placeholder was not.
@mmalerba mmalerba added discussion P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 23, 2017
@jelbourn
Copy link
Member

What demo? In demo-app/ or in material-examples/?

@mmalerba
Copy link
Contributor Author

demo app, didn't check the examples

@jelbourn jelbourn added P4 A relatively minor issue that is not relevant to core functions and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 24, 2017
@kara kara removed their assignment Jun 26, 2017
@jelbourn jelbourn assigned devversion and unassigned jelbourn and mmalerba Jan 9, 2018
devversion added a commit to devversion/material2 that referenced this issue Jan 15, 2018
@devversion
fix(input): respect text-align value from form-field
37d8d55 
User agent stylesheets set the text-align of inputs explicitly to "start". Those can be easily overwritten by targeting the input element using a simple CSS selector, but since the text-align will be applied most of the time on the `mat-form-field` to also align the placeholder/label, the alignment should be inherited on the input.

Related to angular#5332
@devversion devversion mentioned this issue Jan 15, 2018
Merged
jelbourn pushed a commit that referenced this issue Jan 20, 2018
@devversion @jelbourn
fix(input): respect text-align value from form-field
8583aca 
User agent stylesheets set the text-align of inputs explicitly to "start". Those can be easily overwritten by targeting the input element using a simple CSS selector, but since the text-align will be applied most of the time on the `mat-form-field` to also align the placeholder/label, the alignment should be inherited on the input.

Related to #5332
jelbourn pushed a commit that referenced this issue Jan 23, 2018
@devversion @jelbourn
fix(input): respect text-align value from form-field (#9397)
5136361 
User agent stylesheets set the text-align of inputs explicitly to "start". Those can be easily overwritten by targeting the input element using a simple CSS selector, but since the text-align will be applied most of the time on the `mat-form-field` to also align the placeholder/label, the alignment should be inherited on the input.

Related to #5332
@mmalerba mmalerba added needs: discussion Further discussion with the team is needed before proceeding and removed discussion labels Mar 3, 2020
@crisbeto
Copy link
Member

Looks like this was resolved a long time ago, but the issue was never closed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
area: material/input needs: discussion Further discussion with the team is needed before proceeding P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jelbourn @kara @crisbeto @devversion @mmalerba @andrewseguin