Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(input-demo): remove align input binding #5272

Closed
BaimosTechnologies opened this issue Jun 21, 2017 · 1 comment · Fixed by #5280
Closed

bug(input-demo): remove align input binding #5272

BaimosTechnologies opened this issue Jun 21, 2017 · 1 comment · Fixed by #5280
Assignees
@devversion

Comments

@BaimosTechnologies
Copy link

Bug, feature request, or proposal:

Caused by #5141

I think the .demo-text-align-end class breaks the .mat-input-underline text-align, which causes the underline to align to the end instead to left, see instances below taken from input demo page:

screen shot 2017-06-19 at 11 36 06
screen shot 2017-06-19 at 11 37 02
screen shot 2017-06-19 at 11 37 21

What is the expected behavior?

The underline should be aligned to the left

What is the current behavior?

The underline is aligned at the end

What are the steps to reproduce?

Build the material project, navigate to input-demo.html and focus in the input fields in the images above.

What is the use-case or motivation for changing an existing behavior?

Input demo page should not have this error anymore.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

2.0.0-beta7

Is there anything else we should know?

Also commented on the pull request #5141, nobody answered so I opened this new issue.
@devversion devversion self-assigned this Jun 21, 2017
devversion added a commit to devversion/material2 that referenced this issue Jun 21, 2017
@devversion
fix(input): underline showing at end if text-align is set
8f80734 
Recently the `align` input binding has been removed in favor of the CSS property `text-align`.

If a developer sets the `text-align` property to `end` the text will start from the end and also the input underline will show incorrectly start from the end.

Setting the absolute positioned underline to `left: 0` ensures that the underline always shows-up correctly (because the `mat-input-underline` is inside of a relative container)

Fixes angular#5272
@devversion devversion mentioned this issue Jun 21, 2017
Merged
jelbourn pushed a commit that referenced this issue Jun 22, 2017
@devversion @jelbourn
fix(input): underline showing at end if text-align is set (#5280)
5c9391d 
Recently the `align` input binding has been removed in favor of the CSS property `text-align`.

If a developer sets the `text-align` property to `end` the text will start from the end and also the input underline will show incorrectly start from the end.

Setting the absolute positioned underline to `left: 0` ensures that the underline always shows-up correctly (because the `mat-input-underline` is inside of a relative container)

Fixes #5272
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input): underline showing at end if text-align is set devversion/material2
2 participants
@BaimosTechnologies @devversion