Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): detach method returns undefined #7449

Merged
merged 1 commit into from
Oct 3, 2017
Merged

fix(overlay): detach method returns undefined #7449

merged 1 commit into from
Oct 3, 2017

Commits on Oct 1, 2017

  1. fix(overlay): detach method returns undefined 

    Currently the JSDoc of the `detach` method describes that the method returns a Promise if the detaching is done. This is not the case and just `undefined` is being returned because every `PortalHost` implementation inside of the CDK is synchronously detaching the view.

In the future it might be useful to change this method back to a `Promise` in favor of animations, but for now it doesn't make sense return a `Promise` because the `attach` method is also synchronous.

Fixes angular#7408
    @devversion
    devversion committed Oct 1, 2017
    Configuration menu
    Copy the full SHA
    e4a5ac8 View commit details
    Browse the repository at this point in the history