Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): detach method returns undefined #7449

Merged
merged 1 commit into from
Oct 3, 2017
Merged

fix(overlay): detach method returns undefined #7449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cdk/overlay/overlay-ref.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ export class OverlayRef implements PortalHost {

/**
* Detaches an overlay from a portal.
* @returns Resolves when the overlay has been detached.
* @returns The portal detachment result.
*/
detach(): Promise<any> {
detach(): any {
this.detachBackdrop();

// When the overlay is detached, the pane element should disable pointer events.
Expand All @@ -99,7 +99,7 @@ export class OverlayRef implements PortalHost {
this._config.scrollStrategy.disable();
}

let detachmentResult = this._portalHost.detach();
const detachmentResult = this._portalHost.detach();

// Only emit after everything is detached.
this._detachments.next();
Expand Down