-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An undefined
value is returned by OverlayRef.detach()
#7408
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
josephperrott
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
code health
labels
Sep 29, 2017
devversion
added a commit
to devversion/material2
that referenced
this issue
Sep 30, 2017
Currently the JSDoc of the `detach` method describes that the method returns a Promise if the detaching is done. This is not the case and just `undefined` is being returned because every `PortalHost` implementation inside of the CDK is synchronously detaching the view. In the future it might be useful to change this method back to a `Promise` in favor of animations, but for now it doesn't make sense return a `Promise` because the `attach` method is also synchronous. Fixes angular#7408
devversion
added a commit
to devversion/material2
that referenced
this issue
Oct 1, 2017
Currently the JSDoc of the `detach` method describes that the method returns a Promise if the detaching is done. This is not the case and just `undefined` is being returned because every `PortalHost` implementation inside of the CDK is synchronously detaching the view. In the future it might be useful to change this method back to a `Promise` in favor of animations, but for now it doesn't make sense return a `Promise` because the `attach` method is also synchronous. Fixes angular#7408
kara
pushed a commit
that referenced
this issue
Oct 3, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Bug, feature request, or proposal:
Bug
What is the expected behavior?
What is the current behavior?
An
undefined
value is returned byOverlayRef.detach()
What are the steps to reproduce?
StackBlitz: https://angular-material2-issue-qqyacc.stackblitz.io/
StackBlitz export: angular-material2-issue.zip
The plunker starter btw errors with no modifications:
What is the use-case or motivation for changing an existing behavior?
Is it a bug?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
@angular/cdk: 2.0.0-beta.11
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: