fix(material-experimental/mdc-progress-spinner): fix noop animation #21359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: patch
google-cla
bot
added
the
cla: yes
annieyw
approved these changes
Dec 15, 2020
crisbeto
reviewed
Dec 15, 2020
| @include mdc-circular-progress-core-styles($query: animation); | ||
| } | ||
|
|
||
| // Render the indeterminate spinner as a complete circle when animations are off | ||
| ._mat-animation-noopable .mdc-circular-progress__indeterminate-container circle { |
There was a problem hiding this comment.
I think you can target ._mat-animation-noopable .mdc-circular-progress__determinate-circle directly. The specificity shouldn't matter since you're using !important.
There was a problem hiding this comment.
I was hoping so, but they apply the styles directly to the element dynamically so there's no way to override it via CSS unless we use !important
There was a problem hiding this comment.
I meant that changing the selector to the one I mentioned would reduce the specificity, but it won't matter if we keep the !important.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 18, 2020
…orking Seems like a regression from angular#21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 18, 2020
…ion not working Seems like a regression from angular#21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations.
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Dec 22, 2020
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…ion not working (#21391) Seems like a regression from #21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations. (cherry picked from commit 37a9c4e)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…ion not working (angular#21391) Seems like a regression from angular#21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animations were still being shown because the selector
:not(._mat-animation-noopable)by itself matched plenty of parent elements. This specifies the right parent element that should be checked.Also, this forces the spinner to be a complete circle when there are no animations, rather than some odd looking broken spinner shape