Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-progress-spinner): fix noop animation #21359

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix(material-experimental/mdc-progress-spinner): fix noop animation #21359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/material-experimental/mdc-progress-spinner/progress-spinner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
overflow: hidden;
}

:not(._mat-animation-noopable) {
.mat-mdc-progress-spinner:not(._mat-animation-noopable) {
@include mdc-circular-progress-core-styles($query: animation);
}

// Render the indeterminate spinner as a complete circle when animations are off
._mat-animation-noopable .mdc-circular-progress__indeterminate-container circle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can target ._mat-animation-noopable .mdc-circular-progress__determinate-circle directly. The specificity shouldn't matter since you're using !important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping so, but they apply the styles directly to the element dynamically so there's no way to override it via CSS unless we use !important

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that changing the selector to the one I mentioned would reduce the specificity, but it won't matter if we keep the !important.

stroke-dasharray: 0 !important;
}