fix(material-experimental/mdc-progress-spinner): indeterminate animation not working #21391
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
…ion not working Seems like a regression from angular#21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations.
crisbeto
force-pushed
the
mdc-spinner-regression
branch
from
abaa3e6 to
f9a62aa
Compare
crisbeto
changed the title
andrewseguin
approved these changes
Dec 18, 2020
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…ion not working (#21391) Seems like a regression from #21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations. (cherry picked from commit 37a9c4e)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…ion not working (angular#21391) Seems like a regression from angular#21359. We can't use `:not` to apply the animation styles, because MDC's mixins target `.mdc-progress-spinner`, rather than `&`. These changes use the same manual approach as other components to disable the animations.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a regression from #21359. We can't use
:notto apply the animation styles, because MDC's mixins target.mdc-progress-spinner, rather than&.These changes use the same manual approach as other components to disable the animations.
For reference, the circle looks like this in master:
