chore($resource): Use shallow copy instead of angular.copy #5252
Conversation
Replace calls to angular.copy with calls to a new function, shallowClearAndCopy. Add calls to copy for cache access in $http in order to prevent modification of cached data. Results in a measurable improvement to the startup time of complex apps within Google.
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Not sure if this change warrants any new unit tests. Also, the $http change is a slight change in behavior for cases where it is not being used by way of $resource (Previously $resource was doing all of the copying). I can revert the changes to $http if that's preferrable. |
|
is this a breaking change in any way? |
| @@ -465,7 +484,7 @@ angular.module('ngResource', ['ng']). | |||
| if (data) { | |||
| // Need to convert action.isArray to boolean in case it is undefined | |||
| // jshint -W018 | |||
| if ( angular.isArray(data) !== (!!action.isArray) ) { | |||
| if (angular.isArray(data) !== (!!action.isArray) ) { | |||
There was a problem hiding this comment.
also remove the trailing space while you are at it :)
|
The resource part should not be breaking. The $http part would break code that depends on being able to modify the cache by way of reading from it. |
The 1.2 release fixed the documented pitfall at 909cabd by isolating only the isolated directive's scope. Closes angular#5179
ghost
assigned
|
this looks good to me (except for not being squashed into a single commit with a good commit message). I believe that we can't merge this until #5276 lands, otherwise the $resource instance could modify the cache. |
…propriate Due to an earlier change, ngModelWatch() no longer returns a value to the caller. This means the digest loop has no way to tell if the watch actually modified anything and so can not schedule another pass. This means any watches that watch form or model controller changes (e.g. watches on form.$valid) that are scheduled prior to an ngModelWatch() will not be able to see any changes made therin. This commit fixes this behavior by returning the latest evaluated ng-model value. Closes angular#5258 Closes angular#5282
If jshint (or any other ci-check) fails, Travis marks the build as "Errored" which I don't think is desider: https://travis-ci.org/angular/angular.js/builds/14938896
The priority of ngInit is adjusted to occur before ngInclude, and after ngController. This enables ngInit to initiallize values in a controller's scope, and also to initiallize values before ngInclude executes. Closes angular#5167 Closes angular#5208
…ansclusion Closes angular#4716 Closes angular#4871 Closes angular#5021 Closes angular#5278
|
I closed #5276 as it actually does nothing. The data going in and out of the $http cache is always a string, so angular.copy has no effect. |
Replace calls to angular.copy with calls to a new function, shallowClearAndCopy. Add calls to copy for cache access in $http in order to prevent modification of cached data. Results in a measurable improvement to the startup time of complex apps within Google.
…into shallow-copy
|
I've managed to completely ruin this branch with rebase, so once I figure out what's wrong I'll get it re-updated. |
|
Opened a new PR: #5300 with a cleaned up branch. |
chore($resource): Use shallow copy instead of angular.copy
Replace calls to angular.copy with calls to a new function, shallowClearAndCopy.
Add calls to copy for cache access in $http in order to prevent modification of cached data.
Results in a measurable improvement to the startup time of complex apps within Google.