Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

'leave' animations do not work when using ng-include and ng-repeat on an element #5278

Closed
gregolsky opened this issue Dec 4, 2013 · 0 comments
Closed

'leave' animations do not work when using ng-include and ng-repeat on an element #5278

gregolsky opened this issue Dec 4, 2013 · 0 comments

Comments

@gregolsky
Copy link
Contributor

I am opening this ticket as @matsko suggested. Continuing from #4871.

Here is the plunkr with an example of the issue:
http://plnkr.co/edit/iVrtMJg92Iip9arTLXpx?p=preview

Please try to remove an element to reproduce the problem.

After @matsko:
"It looks like both ngInclude and ngRepeat are competing for who gets to animate the leave operation. Normally this isn't a problem, but when a destructive DOM operation happens which removes the element before the next animation takes place, then this leads up to the next animation having no element to perform the animation on."
@matsko matsko mentioned this issue Dec 5, 2013
Closed
matsko added a commit to matsko/angular.js that referenced this issue Dec 5, 2013
@matsko
fix($animate): ensure animations work with directives that share a tr…
15fde6c 
…ansclusion

Closes angular#4716
Closes angular#4871
Closes angular#5021
Closes angular#5278
@matsko matsko closed this as completed in 958d3d5 Dec 5, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix($animate): ensure animations work with directives that share a tr…
17aca7d 
…ansclusion

Closes angular#4716
Closes angular#4871
Closes angular#5021
Closes angular#5278
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix($animate): ensure animations work with directives that share a tr…
ee6c8fb 
…ansclusion

Closes angular#4716
Closes angular#4871
Closes angular#5021
Closes angular#5278
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix($animate): ensure animations work with directives that share a transclusion matsko/angular.js
1 participant
@gregolsky