Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

$destroy on root scope doesn't do anything #5169

Closed
IgorMinar opened this issue Nov 27, 2013 · 1 comment
Closed

$destroy on root scope doesn't do anything #5169

IgorMinar opened this issue Nov 27, 2013 · 1 comment
Assignees
@jeffbcross
Labels
frequency: moderate type: bug
Milestone
1.2.4

Comments

@IgorMinar
Copy link
Contributor

see

angular.js/src/ng/rootScope.js

Line 671 in 38fb542

if ($rootScope == this || this.$$destroyed) return;

we should at least broadcast the $destroy event and mark the scope as destroyed.
@IgorMinar
Copy link
Contributor Author

this issue was created as a result of discussion at #4864

@IgorMinar IgorMinar mentioned this issue Nov 27, 2013
Closed
@ghost ghost assigned IgorMinar Nov 27, 2013
@ghost ghost assigned jeffbcross Dec 4, 2013
jeffbcross added a commit to jeffbcross/angular.js that referenced this issue Dec 4, 2013
@jeffbcross
fix($rootScope): broadcast $destroy event on $rootScope
544ebcd 
Fixes angular#5169
@jeffbcross jeffbcross mentioned this issue Dec 4, 2013
Closed
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@jeffbcross @jamesdaily
fix($rootScope): broadcast $destroy event on $rootScope
101f382 
Fixes angular#5169
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@jeffbcross @jamesdaily
fix($rootScope): broadcast $destroy event on $rootScope
24713c9 
Fixes angular#5169
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeffbcross jeffbcross

Labels
frequency: moderate type: bug
Projects
None yet
Milestone
1.2.4
Development

Successfully merging a pull request may close this issue.

fix($rootScope): broadcast $destroy event on $rootScope jeffbcross/angular.js
2 participants
@IgorMinar @jeffbcross