Master #4391
Closed
Master #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs can now run using angular 1.3.16. This didn't work before because the grunt-ngdocs version that was being used did not support angular 1.3
Update grunt-ngdocs
There was a warning when defaulting to using "string" as a type for a column. It was causing more confusion than the help it was providing so it's been removed. Closes #3662
The headerRowHeight option hasn't done anything for a long time. This change removes it from the docs and specifies how to alter header height with CSS. Closes #3665
Adds ui-grid-one-bind directive set to core
GridApi.suppressEvents should suppress all the handlers
thanks to @500tech-user and @Jacquelin for PR's that led to this fix
The param string on uiGridOneBindIdGrid was wrong
Otherwise some character patterns would have unexpected behaviour. For example, '$$' would be replaced with a '$'.
…pure-string Ensure cellFilters in gridClassFactory are passed without modifications
Fixes queue refresh api registration
Adds information about Jasmine and Protractor tests and how to run single tests.
208 was disabled because the cancelFilterInColumn method wasn't working correctly however it seems to be working fine now.
The $scope.$watch used `===` for equality comparisons by default and 1.3 uses `angular.equals`. The desired behaior is acheived using `angular.equals`.
Fixes one bind tests failing with Angular 1.2
Enables e2e test on 208
For some reason Bower won't install 1.3.x when the version spec says '>=1.2.16 <=1.3.x'. It installs 1.2.28 instead. This change explicitly states 1.3.14 as the latest allowable. Closes #3865
Should download pdf similar to downloading a csv when in IE, whereas all other browsers should open the pdf in place in a new tab (something that pdfMake cannot do in IE).
Export pdf in IE, extend tutorials to link to API doco
#3795 raise sortChanged with proper arguments when grid state is restored
fix(gridUtil): Fixes gridUtil.off.mousewheel event handler
Partially fix jumpy infiniteScroll scrolling
missing colon in site.css
docs(typo): fix typo in pagination docs
fix(grouping): #4318 fixes the moveGroupColumn bug, return original columns instead of null
Makes the gitter chat buttons to more prominent locations. This will hopefully help mitigate the number of issues and increase the number of questions asked in chat.
docs: Adds Gitter badge readme and site Homepage
…ator feat(core): Adds sort priority number to header
Adds some guidelines around git messages. This will help get more commits into the changelog.
Added "expandedRowHeight" property to the expanded row. If it is not defined, the grid's default is used. Changed the template files to use the "expandedRowHeight" instead of the grid's default. Added "rowExpandedBeforeStateChanged" event to "expandable" feature Can now hook to the event before the change. One scenario this can be helpful is to dynamically change the expandedRowHeight
…cteam Dynamically expanded row height
Adds Commit Message Guidelines to Changelog
Fixes typo in contributing.
This option allows you to specify how a column's sort direction should be cycled as the heading is repeatedly clicked. The default value, [null,ASC,DESC], preserves the existing behavior.
feat(core): add sortDirectionCycle column option
Fix bug: expectRowCount will get doubled row count if there're pinned columns
If your data is completely replaced by another array, then you need to call clearSelectedRows and it wasn't resetting the selectionCount
|
I'm really not sure what this is for? |
|
I'm not sure what the purpose of this commit is. Is this for 2.0.x? |
|
Much, much too complicated of a PR to consider merging. A PR should contain ONLY the change you are making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4389