Ensure cellFilters in gridClassFactory are passed without modifications #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise some character patterns would have unexpected behaviour. For example, '$$' would be replaced with a '$'.
swalters
added a commit
that referenced
this pull request
Jun 22, 2015
…pure-string Ensure cellFilters in gridClassFactory are passed without modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have stored some precalculated data in UI-grid's row with the
$$prefix which we access in the column with Angular's filter. Regardless of if that is the best solution or not, I found the following unexpected behaviour:A cell filter
causes cell's filter template to be replaced with
. It is missing one dollar sign.
This is caused by String.prototype.replace()'s special replacement patterns. We can prevent this by passing the second parameter with an anonymous function in
gridClassFactory.js.