feat(core): Adds sort priority number to header #4257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers now show the sort priority of the column. This is done using a subscript tag that is pulled closer to the sort direction icon.
|
I like this a lot. @c0bra if you're cool with it, please merge. (I seem to remember you having some comments about this feature in 2.x) |
|
@JLLeitschuh I like the numbers. I started to put the sort icon and the column menu together, but never found the time to get it ready for a PR. There is a plunker linked in #3992. Would you be up for combing that into your feature? I have implemented it in my app, but it is a simplified because we always have a column menu. |
|
@AgDude I think thats outside the scope of this PR and outside of the time constraints that I have at the moment. |
JLLeitschuh
added a commit
that referenced
this pull request
Sep 8, 2015
…ator feat(core): Adds sort priority number to header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers now show the sort priority of the column.
This is done using a subscript tag that is pulled closer to the sort
direction icon.