Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I2I: reduce size of AMPHTML ads runtime (project: inabox lite) #22867

Closed
7 tasks done
lannka opened this issue Jun 17, 2019 · 2 comments
Closed
7 tasks done

I2I: reduce size of AMPHTML ads runtime (project: inabox lite) #22867

lannka opened this issue Jun 17, 2019 · 2 comments
Assignees
@lannka
Labels
Component: AMPHTML ads INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P2: Soon Type: Feature Request WG: monetization

Comments

@lannka
Copy link
Contributor

lannka commented Jun 17, 2019 •
edited
Loading

Current total: 285K (compiled, before gzip)

Separately, we will need more example ads for local testing. #23629
We will also need more e2e test coverage. #24038
@lannka lannka added INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code WG: monetization Type: Feature Request P2: Soon labels Jun 17, 2019
@lannka lannka self-assigned this Jun 17, 2019
This was referenced Jun 17, 2019
Closed
Merged
Merged
Merged
Closed
This was referenced Jun 25, 2019
Merged
Merged
@calebcordry calebcordry added Component: AMPHTML ads INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code and removed INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code labels Jul 2, 2019
@lannka lannka mentioned this issue Jul 2, 2019
Closed
This was referenced Jul 12, 2019
Closed
Closed
This was referenced Jul 30, 2019
Closed
Closed
Closed
Closed
This was referenced Aug 23, 2019
Merged
Merged
@lannka
Copy link
Contributor Author

lannka commented Aug 23, 2019

Spin off service lazy load to a separate issue for tracking (#24188). Also we might scope it up to cover regular AMP runtime as well.

This was referenced Aug 30, 2019
Merged
Closed
@lannka lannka closed this as completed Sep 5, 2019
@lannka
Copy link
Contributor Author

lannka commented Sep 5, 2019

After all the above changes, the binary size is 210KB now.

@lannka lannka mentioned this issue Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lannka lannka

Labels
Component: AMPHTML ads INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P2: Soon Type: Feature Request WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lannka @calebcordry