Inabox: remove unnecessary dependency on storage services. #22888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
reviewed
Jun 25, 2019
src/service/core-services.js
Outdated
| installCidService(ampdoc); | ||
| if (!opt_inabox) { | ||
| // For security, storage service is not supported in inabox. | ||
| installCidService(ampdoc); |
There was a problem hiding this comment.
Does the installation order matter? Can we combine the opt_inabox check to one.
There was a problem hiding this comment.
According to the comment above, the order matters.
src/service/core-services.js
Outdated
| @@ -79,7 +79,10 @@ export function installRuntimeServices(global) { | |||
| export function installAmpdocServices(ampdoc, opt_initParams, opt_inabox) { | |||
| // Order is important! | |||
| installUrlForDoc(ampdoc); | |||
| installCidService(ampdoc); | |||
| if (!opt_inabox) { | |||
| // For security, storage service is not supported in inabox. | |||
There was a problem hiding this comment.
comment code doesn't match : )
src/inabox/amp-inabox.js
Outdated
| // For security, storage and CLIENT_ID are not supported in inabox. | ||
| // Fail early with console errors for any attempt of access. | ||
| unsupportedService(ampdoc, 'storage'); | ||
| unsupportedService(ampdoc, 'cid'); |
There was a problem hiding this comment.
amphtml/src/service/url-replacements-impl.js
Lines 290 to 294 in d7a0dde
I'm hoping that we can remove this. Instead of make cid service unsupported, can we create a fake cid service and return
null for get() method instead?
There was a problem hiding this comment.
I like that. Removed CID related change from this PR. Will address that separately.
There was a problem hiding this comment.
Addressed here: #23018
lannka
changed the title
lannka
changed the title
zhouyx
approved these changes
Jun 26, 2019
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
…t#22888) * Inabox: remove unnecessary dependencies cid & storage services. * Undo CID * Undo CID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of amp4ads-v0.js from 273.5KB to 271KB
for #22867