-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have binary size check for amp4ads-v0.js #23307
Comments
Assigning to @danielrozenberg. @lannka I assume you're interested in the |
@rsimha yep, that sounds better. Thanks! |
Can we prioritize this item? We just got a bundle size regression: #23487 It's very easy to pull in regular AMP code to AMP4ADS and cause a big size regression. |
@zhouyx do you want a size check for amp-analytics-0.1.js ? :-) |
Adding @erwinmombay who is going to work on some of the bundle-size feature requests. |
I'm trying to think what's the value for such a check for amp-analytics.js. I could definitely see the value if later on we lazy load feature bundles, but not right now. It would be great to introduce such check for amp-analytics.js, but I also don't think that's super urgent right now. Really based on the effort and the cost on adding such check. |
/cc @powerivq |
Un-assigning @erwinmombay who no longer works on this. Tracking the bundle size of other binaries is definitely possible, although it will need non-trivial changes on the /cc @ampproject/wg-infra |
Fixed |
As to ensure the success of the inabox-lite project #22867, we would like to monitor the binary size for amp4ads-v0.js in the same way as v0.js.
@rsimha is this something your team can help? Thanks
The text was updated successfully, but these errors were encountered: