Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master Feature] Improve performance on AMPHTML ads when served to non-AMP pages #12382

Closed
jasti opened this issue Dec 8, 2017 · 6 comments
Closed

Comments

@jasti
Copy link
Contributor

jasti commented Dec 8, 2017

@lannka and @keithwrightbos to breakdown to tasks

  • Reduce the size of the ads runtime
@jasti jasti added this to the Prioritized FRs milestone Dec 8, 2017
@jasti jasti changed the title Improve performance on AMPHTML ads when served to non-AMP pages [Feature] Improve performance on AMPHTML ads when served to non-AMP pages Jan 18, 2018
@keithwrightbos
Copy link
Contributor

This is complete. AMPHTML ads on non-AMP pages served via GPT are now validated and optimized to include full version paths for AMP scripts, server side rendering with inline CSS, and tag injection within amp-img and amp-pixel elements.

@jasti
Copy link
Contributor Author

jasti commented Apr 3, 2018

In most cases AMPHTML ads are already more performant than non-AMP pages. This is certainly the case when compared to HTML5 creatives. However, when compared to simply image creatives, the AMPHTML variant is slower because it needs to download entire runtime to render the ad. Optimize the AMPHTML ad in a way that it's always better than a non-AMPHTML ad.

Performance in this case means 'optimizing to get the creative to render as quickly as possible' which translates to increased viewability, higher click through rate of the ad.

@jasti jasti reopened this Apr 3, 2018
@jasti jasti changed the title [Feature] Improve performance on AMPHTML ads when served to non-AMP pages [Master Feature] Improve performance on AMPHTML ads when served to non-AMP pages Apr 3, 2018
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

@jeffkaufman
Copy link
Contributor

when compared to simply image creatives, the AMPHTML variant is slower because it needs to download entire runtime to render the ad

Server-side rendering can convert the AMPHTML variant to HTML, such that the browser can display the image immediately, without waiting for the runtime to load. This is what Doubleclick has deployed.

I know @lannka has other plans for improving the efficiency of Inabox, like making a separate and much smaller runtime, but I think this is tracked elsewhere?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @keithwrightbos Do you have any updates?

@lannka
Copy link
Contributor

lannka commented Jun 17, 2019

let's track inabox lite work here: #22867

@lannka lannka closed this as completed Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants