Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new test for the simulation of a box created as mesh #290

Closed
wants to merge 38 commits into from

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    4941ec3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e76fe6c View commit details
    Browse the repository at this point in the history
  3. Format and lint

    flferretti authored and lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a2c4109 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    078a3f8 View commit details
    Browse the repository at this point in the history
  5. Skip loading empty meshes

    Co-authored-by: Lorenzo Conti <[email protected]>
    flferretti and lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    003cc71 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4332531 View commit details
    Browse the repository at this point in the history
  7. Address to reviews:

    - Moved mesh parsing logic inside method for creating mesh collisions
    - Removed vs code settings
    - Removed empty mesh parsing test
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2e180c6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1bcf580 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9a596de View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3d8ad9d View commit details
    Browse the repository at this point in the history
  11. Address reviews

    - Remove leftover comments
    - MeshMappingMethods inherit from IntEnum instead of Enum
    - Added center comparison for MeshCollision object
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    67c97d2 View commit details
    Browse the repository at this point in the history
  12. Pre-commit

    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0183c5b View commit details
    Browse the repository at this point in the history
  13. Update __eq__ magic and type hints

    flferretti authored and lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ff40470 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2c920ba View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    4bf1769 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    136e42c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    8c46be3 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    71b0727 View commit details
    Browse the repository at this point in the history
  19. Implemented initial reviews from ami-iit#156

    - Restructured mesh_collision creation method
    - Removed unnecessary hash inheritance
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    433602a View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    40e182d View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    4b9e4b1 View commit details
    Browse the repository at this point in the history
  22. New mesh wrapping algorithms

    - Implemented AAP algorithm
    - Restructured collision parsing to accept the new algorithms
    - Wrote tests for AAP algorithm
    - Updated JaxSim dependencies
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d761cc6 View commit details
    Browse the repository at this point in the history
  23. New mesh wrapping algorithms with relative tests

    - New mesh wrapping algorithms (mesh decimation, object mapping, aap, select points over axis)
    - Implemented tests of above except first algorithm
    - Updated manifold3d dependency (used in object mapping)
    - Restructured meshes module
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d0579f5 View commit details
    Browse the repository at this point in the history
  24. Renamed some parameters

    - Renamed some function paramaeters
    - Added a few tests
    TODO: migrate MeshMapping static class to inheritance structure
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1bc3b07 View commit details
    Browse the repository at this point in the history
  25. Restructured mesh mapping methods to follow inheritance

    - Redefined methods using classes
    - Adapted rod parser to new structure
    - Reimplemented tests with new structure
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    94ecdb2 View commit details
    Browse the repository at this point in the history
  26. Run pre-commit

    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0f8503e View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    d9aabc7 View commit details
    Browse the repository at this point in the history
  28. Removed wrong point selection & added logs

    - Removed a line that would always set the extracted points to the vertices
    - Added a few debug lines using logger
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2c5b603 View commit details
    Browse the repository at this point in the history
  29. Added string magics on wrapping methods

    - Added string magics on mesh wrapping methods for easier logging
    - Added log to indicate number of extracted points
    - Added extra check on objectmapping method
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b9a49f3 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    4570f1e View commit details
    Browse the repository at this point in the history
  31. Added string magics on wrapping methods

    - Added string magics on mesh wrapping methods for easier logging
    - Added log to indicate number of extracted points
    - Added extra check on objectmapping method
    lorycontixd committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    932c4a4 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Implemented reviews

    lorycontixd committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    32e90b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d417927 View commit details
    Browse the repository at this point in the history
  3. Addressed reviews

    - Removed unused dependencies in pyproject.toml
    - Moved from warning to exception if passed mesh is empty
    
    Co-authored-by: Filippo Luca Ferretti <[email protected]>
    lorycontixd and flferretti committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9e64c05 View commit details
    Browse the repository at this point in the history
  4. Updated variable names

    Co-authored-by: Filippo Luca Ferretti <[email protected]>
    lorycontixd and flferretti authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    29aa6f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    57446b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9762d80 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc251cf View commit details
    Browse the repository at this point in the history