Improve metadata positioning in doc list for right to left layouts #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitabarrett
force-pushed
the
improve-doc-list-metadata-rtl
branch
from
9b93d7b to
47b54f8
Compare
andysellick
requested changes
Jul 17, 2018
|
|
||
| .direction-rtl & { | ||
| float: right; | ||
| } |
There was a problem hiding this comment.
Does this also need to have the padding-right changed to padding-left? The indenting of the date doesn't look quite right...
| path: '/government/publications/school-exclusion' | ||
| metadata: | ||
| public_updated_at: 2017-07-19 15:01:48 | ||
| document_type: 'Statutory guidance' |
There was a problem hiding this comment.
Would be good to test a rtl example with some gem-c-document-list__item-context elements included.
| @@ -32,6 +32,10 @@ | |||
| float: left; | |||
| list-style: none; | |||
| padding-right: $gutter-two-thirds; | |||
|
|
|||
| .direction-rtl & { | |||
| float: right; | |||
There was a problem hiding this comment.
Instead of floating this right you could simply take the float left off the original element style and replace it with display inline-block - it's then influenced by the text direction but uses less CSS (of course, I haven't tested this cross browser but I think it should work).
There was a problem hiding this comment.
That sounds good, I wonder why we used float to start with.. I'll have a go 👍
vanitabarrett
force-pushed
the
improve-doc-list-metadata-rtl
branch
from
47b54f8 to
3bffb27
Compare
vanitabarrett
force-pushed
the
improve-doc-list-metadata-rtl
branch
from
3bffb27 to
40b73bc
Compare
Float the metadata to the right when on a right to left layout. Otherwise it's difficult to see how the metadata is related to the document list item heading
vanitabarrett
force-pushed
the
improve-doc-list-metadata-rtl
branch
from
40b73bc to
7f0a84f
Compare
andysellick
approved these changes
Jul 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the metadata to the right when on a right to left layout. Otherwise it's difficult to see how the metadata is related to the document list item heading
Before
After
Component guide: https://govuk-publishing-compon-pr-429.herokuapp.com/component-guide/document_list