Skip to content

Commit

Permalink
Improve metadata positioning in doc list for rtl
Browse files Browse the repository at this point in the history
Float the metadata to the right when on a right to left layout. Otherwise it's difficult to see how the metadata is related to the document list item heading
  • Loading branch information
Vanita Barrett committed Jul 17, 2018
1 parent 1654658 commit 40b73bc
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
useful summary for people upgrading their application, not a replication
of the commit log.

## Unreleased

* Improve metadata positioning in document list for rtl layouts (PR #429)

## 9.5.2

* Attempt to improve Google snippet display (PR #424)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,14 @@

.gem-c-document-list__attribute {
@include core-14;
float: left;
display: inline-block;
list-style: none;
padding-right: $gutter-two-thirds;

.direction-rtl & {
padding-right: 0;
padding-left: $gutter-two-thirds;
}
}

.gem-c-document-list--bottom-margin {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,22 @@ examples:
path: '/government/organisations/advisory-committee-on-the-microbiological-safety-of-food'
context: 'moving to GOV.UK'
description: "Works with 4 agencies and public bodies"
right_to_left:
data:
items:
- link:
text: 'School behaviour and attendance: parental responsibility measures'
path: '/government/publications/parental-responsibility-measures-for-behaviour-and-attendance'
description: "Statutory guidance for schools, local authorities and the police on dealing with poor attendance and behaviour in school"
metadata:
public_updated_at: 2017-01-05 14:50:33
document_type: 'Statutory guidance'
- link:
text: 'Forestry Commission'
path: '/government/organisations/forestry-commission'
context: 'separate website'
metadata:
public_updated_at: 2017-07-19 15:01:48
document_type: 'Organisation'
context:
right_to_left: true

0 comments on commit 40b73bc

Please sign in to comment.