Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve metadata positioning in doc list for right to left layouts #429

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Improve metadata positioning in doc list for right to left layouts #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
useful summary for people upgrading their application, not a replication
of the commit log.

## Unreleased

* Improve metadata positioning in document list for rtl layouts (PR #429)

## 9.5.2

* Attempt to improve Google snippet display (PR #424)
Expand Down
12 changes: 11 additions & 1 deletion app/assets/stylesheets/govuk_publishing_components/components/_document-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

.gem-c-document-list__item-title--context {
margin-right: $gutter-one-third;

.direction-rtl & {
margin-right: 0;
margin-left: $gutter-one-third;
}
}

.gem-c-document-list__item-context {
Expand All @@ -29,9 +34,14 @@

.gem-c-document-list__attribute {
@include core-14;
float: left;
display: inline-block;
list-style: none;
padding-right: $gutter-two-thirds;

.direction-rtl & {
padding-right: 0;
padding-left: $gutter-two-thirds;
}
}

.gem-c-document-list--bottom-margin {
Expand Down
19 changes: 19 additions & 0 deletions app/views/govuk_publishing_components/components/docs/document_list.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,22 @@ examples:
path: '/government/organisations/advisory-committee-on-the-microbiological-safety-of-food'
context: 'moving to GOV.UK'
description: "Works with 4 agencies and public bodies"
right_to_left:
data:
items:
- link:
text: 'School behaviour and attendance: parental responsibility measures'
path: '/government/publications/parental-responsibility-measures-for-behaviour-and-attendance'
description: "Statutory guidance for schools, local authorities and the police on dealing with poor attendance and behaviour in school"
metadata:
public_updated_at: 2017-01-05 14:50:33
document_type: 'Statutory guidance'
- link:
text: 'Forestry Commission'
path: '/government/organisations/forestry-commission'
context: 'separate website'
metadata:
public_updated_at: 2017-07-19 15:01:48
document_type: 'Organisation'
context:
right_to_left: true