Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend layout for public with account components #2255

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Extend layout for public with account components #2255

merged 1 commit into from
Aug 12, 2021

Conversation

danacotoran
Copy link
Contributor

@danacotoran danacotoran commented Aug 9, 2021 •
edited
Loading

What

Update layout_for_public component to support GOVUK Account components.

Why

Some account-related components, contents, and CSS are repeated across different apps on GOVUK.

The first instance of this was when we relocated the account homepage from the govuk-account-manager-app to the frontend app, which meant that some of the page furniture and content was duplicated between those apps.

More recently, the accounts team are working towards the goal of single page notifications which will enable users who have linked their email notifications address and their GOVUK account email address to manage their email subscriptions through their account.

Part of this work is making the email management pages (rendered by email-alert-frontend) look the same as the account manager when the user is authenticated with a linked account. Preview:

Screenshot 2021-08-05 at 18 02 13

That would make it three separate apps where page furniture and content are repeated to achieve the same layout.

The purpose of this PR is to extend layout_for_public so that it can be used as a "shell" for account (or "account-style" pages).

Visual changes

Existing variations of the component will remain unchanged. A few options have been introduced to support the main GOVUK Account layout variations. The intention is for this to be used with a layout template in static (or, in the case of the govuk-account-manager-prototype app, be used directly in the application layout)

Related:

https://trello.com/c/F0ZDY0RC

@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 9, 2021 16:09 Inactive
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 9, 2021 16:11 Inactive
@danacotoran danacotoran force-pushed the public-layout-for-account branch from 5b9c2de to a76476d Compare August 9, 2021 16:28
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 9, 2021 16:29 Inactive
@danacotoran danacotoran force-pushed the public-layout-for-account branch from a76476d to e720999 Compare August 9, 2021 16:34
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 9, 2021 16:35 Inactive
@danacotoran danacotoran force-pushed the public-layout-for-account branch from e720999 to fcd6679 Compare August 9, 2021 16:38
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 9, 2021 16:38 Inactive
@danacotoran danacotoran changed the title WIP: Update layout for public for account wrapper WIP: Extend layout for public with account components Aug 9, 2021
@danacotoran danacotoran changed the title WIP: Extend layout for public with account components Extend layout for public with account components Aug 10, 2021
@danacotoran danacotoran mentioned this pull request Aug 10, 2021
Merged
@danacotoran danacotoran marked this pull request as ready for review August 10, 2021 08:48
@danacotoran danacotoran mentioned this pull request Aug 10, 2021
Closed
@danacotoran danacotoran force-pushed the public-layout-for-account branch from fcd6679 to 1286670 Compare August 10, 2021 08:53
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 10, 2021 08:54 Inactive
@danacotoran danacotoran mentioned this pull request Aug 10, 2021
Merged
@danacotoran danacotoran force-pushed the public-layout-for-account branch from 1286670 to 1d115ef Compare August 11, 2021 09:50
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 11, 2021 09:50 Inactive
injms
injms approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@injms injms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments shouldn't be blockers on this - and I think they're indicative of a possible future problem (do components have too many uses?) that we should solve as a community.

@danacotoran danacotoran force-pushed the public-layout-for-account branch from 1d115ef to 364a7bb Compare August 11, 2021 15:20
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 11, 2021 15:21 Inactive
andysellick
andysellick reviewed Aug 11, 2021
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apols, got half way through reviewing this earlier and completely forgot about it. Looks good, some minor comments.

app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb Outdated Show resolved Hide resolved
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 11, 2021 15:38 Inactive
@danacotoran danacotoran force-pushed the public-layout-for-account branch from cf06321 to 016e925 Compare August 12, 2021 08:44
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 12, 2021 08:44 Inactive
@danacotoran
Extend layout for public with account components
a474f81 
Update layout_for_public component to support GOVUK account components.
Existing variations of the component will remain unchanged, but a few
options have been introduced to support the main GOVUK account layout
variations.

The intention is for this to be used with a layout template in static,
to apply account-like page furniture to pages that should have the
account layout, while not being rendered by the
govuk-account-manager-prototype app.
@danacotoran danacotoran force-pushed the public-layout-for-account branch from 016e925 to a474f81 Compare August 12, 2021 08:50
@bevanloon bevanloon temporarily deployed to govuk-publis-public-lay-6umaia August 12, 2021 08:50 Inactive
@danacotoran danacotoran merged commit bad40c9 into master Aug 12, 2021
@danacotoran danacotoran deleted the public-layout-for-account branch August 12, 2021 08:56
injms added a commit that referenced this pull request Aug 12, 2021
@injms
Release v25.3.0
14045e7 
Includes:

* Extend track click script (#2263)
* Fix cookie banner issue (IE10) (#2231)
* Extend layout for public with account components (#2255)
* Update search toggle tracking (#2262)
@injms injms mentioned this pull request Aug 12, 2021
Merged
@danacotoran danacotoran mentioned this pull request Aug 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@injms injms injms approved these changes

@alex-ju alex-ju alex-ju left review comments

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danacotoran @alex-ju @andysellick @injms @bevanloon