Update search toggle tracking #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
reviewed
Aug 11, 2021
app/assets/javascripts/govuk_publishing_components/lib/header-navigation.js
Show resolved
Hide resolved
This will differentiate the events being fire by the menu toggle and the search toggle. Since the toggle code can be used for either, a data attribute needed to be added to make sure that it fires the correct name.
injms
force-pushed
the
update-search-toggle-tracking
branch
from
fd8d991 to
52cb912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the event being fired by the search toggle from
menuOpenedandmenuClosedtosearchOpenedandsearchClosed.It'd be nice to have a more elegant way of doing this, but this fixes a problem that needs to be fixed quickly.
Why
This will differentiate the events being fired by the menu and the search toggles to allow for more accurate analysis of users interactions.
Visual Changes
None.