Use new account layout wrapper for /account/home
#2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new and improved layout template was added, with the intention of being used on pages that should have the account layout, while not being rendered by the govuk-account-manager-prototype app. The improvement in this new template compared to the old one is that all the page furniture for accounts (including the account nav, account feedback footer, account grid layout) is now contained in the template. We can remove these elements, and the content associated with them, from the frontend app, and simply request the gem_layout_account_manager template, without any visual differences taking place.
barrucadu
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new and improved layout template was added, with the intention of being used on pages that should have the account layout, while not being rendered by the
govuk-account-manager-prototypeapp.The improvement in this new template compared to the old one is that all the page furniture for accounts (including the account nav, account feedback footer, account grid layout) is now contained in the template.
Therefore, we can remove these elements, and the content associated with them, from the
frontendapp, and simply request thegem_layout_account_managertemplate, without any visual differences taking place.Related (might be relevant for context):
email-alert-frontend: Account layout for email management pages email-alert-frontend#1106The next step in the process (after the changes in this PR are live) will be to remove the old
gem_layout_accounttemplate fromstatic.