Fix toggled content shown when a checkbox is checked #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This content is currently set to display:block or display:none using toggle(), by instead toggling the .js-hidden class, this takes advantage of .js-enabled .js-hidden set by the govuk_template and fixes a bug where the content to be revealed currently isn’t shown, as the .js-hidden class isn’t removed.
|
Thank you for resolving this @gemmaleigh. |
joelanman
pushed a commit
to joelanman/govuk_elements
that referenced
this pull request
Jun 13, 2016
# 4.1.1 - Update Accessible Media Player to remove dependency on $.browser (PR alphagov#206) # 4.1.0 - Add support for sending the `page` option to `GOVUK.analytics.trackEvent` (PR alphagov#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This content is currently set to display:block or display:none using
toggle().
Instead use toggleClass to add or remove the
.js-hiddenclass, this takesadvantage of
.js-enabled .js-hiddenset by the govuk_template and fixes a bug where the content to be revealed currently isn’t shown, as the.js-hidden class isn’t removed.
This should have been added in #198, but it appears only the fix for radio buttons was committed.