Fix toggled content #198
Merged
Fix toggled content #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than setting display:none and display:block using show(); and hide(), add and remove the js-hidden class.
These are both set by govuk_template, so should not be duplicated here.
|
Happy with this, will merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than setting
display:noneanddisplay:blockusingshow(); andhide(), add and remove the.js-hiddenclass.I think this was introduced by this change to the GOV.UK template, which sets both display:none and visibility:hidden, and the visibility:hidden isn't removed when show and hide are used.
This fixes #197.
I've also removed .js-enabled .js-hidden from GOV.UK elements as this is defined in the template.
It is worth noting that #183 has a much better implementation of the JS for toggles.
cc. @robinwhittleton @edwardhorsford.