Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of errors for date fields #206

Closed
aliuk2012 opened this issue Mar 31, 2016 · 6 comments
Closed

Example of errors for date fields #206

aliuk2012 opened this issue Mar 31, 2016 · 6 comments

Comments

@aliuk2012
Copy link

Currently there are no examples of where errors should be presented or how they should be presented.

My initial thought were that it would be between the day/month/year labels and the fields but what if the validations only relate to one part of the date like an invalid month.

Any other suggests?

This is taken from Register to Vote
image

@aliuk2012
Copy link
Author

Some more examples:
this is the “Apply for a budgeting loan” service, in private beta at the moment
screen shot 2016-03-31 at 11 34 26

This is Money to Prisoners service
screen shot 2016-03-31 at 11 28 04

@joelanman
Copy link
Contributor

the Money to Prisoners example seems a bit overkill - I think the red line on the left for the question, and the border on the fields is sufficient.

I think Register to vote is displaying the error underneath the field because it's handled by javascript, so it shows the error, but avoids jumping the user up the page unexpectedly.

The Apply for a budgeting loan example is the normal, server side pattern.

@glenjamin
Copy link

For reference, apply for a budgeting loan's validation is client-side, but our client-side validation matches the server side validation in logic and display.

When errors are triggered we jump to the top and role="alert" all the validations that have appeared.

@joelanman
Copy link
Contributor

@glenjamin cheers for clarifying :)

@gemmaleigh
Copy link
Contributor

#229 fixes this.

joelanman pushed a commit to joelanman/govuk_elements that referenced this issue Jun 13, 2016
# 4.1.1

- Update Accessible Media Player to remove dependency on $.browser (PR
alphagov#206)

# 4.1.0

- Add support for sending the `page` option to
`GOVUK.analytics.trackEvent` (PR alphagov#203)
@gemmaleigh
Copy link
Contributor

Fixed by #229. The examples can be seen here: http://govuk-elements.herokuapp.com/form-elements/example-form-elements/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants