Add Redis healthcheck #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Jan 12, 2021
There was a problem hiding this comment.
I think we should add a CHANGELOG entry in this PR as well, similar to: 9a7631e#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed
callumknights
force-pushed
the
add-redis-healthcheck
branch
from
8c88f30 to
59914b6
Compare
thomasleese
reviewed
Jan 12, 2021
callumknights
force-pushed
the
add-redis-healthcheck
branch
from
9868400 to
5b10639
Compare
thomasleese
approved these changes
Jan 12, 2021
callumknights
force-pushed
the
add-redis-healthcheck
branch
from
5b10639 to
61c209e
Compare
thomasleese
reviewed
Jan 12, 2021
This was done in response to the work to enable continuous deployment for local-links-manager. Given local-links-manager uses Redis on it's own, without sidekiq, similarly to email-alert-frontend, it made sense to move the recently written healthcheck by @1pretz1 to govuk-app-config so it could be used by both applications. Co-authored-by: Peter Hartshorn <[email protected]> Trello: https://trello.com/c/uAx6eKAQ/2276-activate-continuous-deployment-for-local-links-manager
callumknights
force-pushed
the
add-redis-healthcheck
branch
from
61c209e to
5970941
Compare
thomasleese
approved these changes
Jan 13, 2021
callumknights
added a commit
to alphagov/govuk-puppet
that referenced
this pull request
Jan 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done in response to the work to enable continuous deployment
for local-links-manager. Given local-links-manager uses Redis on it's
own, without sidekiq, similarly to email-alert-frontend, it made sense
to move the recently written healthcheck by @1pretz1 to govuk-app-config
so it could be used by both applications.
Co-authored-by: Peter Hartshorn
[email protected]
Trello: https://trello.com/c/uAx6eKAQ/2276-activate-continuous-deployment-for-local-links-manager