Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Add new healthcheck for Local Links Manager #775

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

callumknights
Copy link
Contributor

Added so continuous deployment can be enabled for
Local Links Manager.

Trello: https://trello.com/c/uAx6eKAQ/2276-activate-continuous-deployment-for-local-links-manager

Testing

You should manually test your PR before merging.

This app doesn't have CI setup, and it would be misleading to do so:
the behaviour of the tests changes depending on the environment they
are run in. You should manually test in applicable environments,
until you are confident your change is not a breaking one.

Example steps to test in Integration:

  • Click "Configure" for the Smokey job
  • Change the "Branch specifier" to the name of your branch
  • Run a new build of the Smokey project and check the results

Deployment

You need to manually deploy your PR after merging.

Steps to deploy a change:

The manual Smokey job will pick up changes on master automatically. You only need to do a manual deployment for the continuous Smokey loop.

Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add @app-local-links-manager to this:

Scenario: Can log in to local-links-manager
When I go to the "local-links-manager" landing page
And I try to login as a user
And I go to the "local-links-manager" landing page
Then I should see "Local Links Manager"
And I should see "Sign out"
And I should see "Council"

@callumknights callumknights force-pushed the add-local-links-manager-healthcheck branch from bed52e2 to 06f04b3 Compare January 14, 2021 15:48
Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just got one comment!

features/local_links_manager.feature Outdated Show resolved Hide resolved
@callumknights callumknights force-pushed the add-local-links-manager-healthcheck branch from 06f04b3 to 7e542d4 Compare January 14, 2021 16:25
@MuriloDalRi
Copy link
Contributor

What @thomasleese said

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants