Redis healthcheck lock #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the naming scheme we've got for the other connectivity healthchecks, such as `database_connectivity`.
In the Redis healthcheck we write and read to a key, so we should check it's doing that to the key we want it to. This also opens up the potential for having different keys.
At the moment we use the same key for our healthcheck. This poses a potential race condition problem as we share the Redis database across all our applications. Instead we can generate a random key for each request which should prevent this problem from happening.
This relates to the race condition problem we've fixed in cfb60c6.
I think the previous version should have been 2.9.0 as it introduced a new feature, but I think bumping this bug fix to 2.9.0 would be confusing.
kevindew
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #183 and fixes a potential race condition. See commits for more details.
Thanks to @kevindew for pointing out the issue.