Allow attributes to be added to anchor items in header, footer, breadcrumbs, tabs and error-summary components #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-993
kr8n3r
changed the title
kr8n3r
force-pushed
the
allow-attributes-on-child-items
branch
from
f8405e9
to
6e07f5f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-993
kr8n3r
changed the title
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-993
kr8n3r
changed the title
kr8n3r
changed the title
added 2 commits
September 11, 2018 11:58
- Allow HTML atrributes to be added to breadcrumb links in the Nunjucks macro template - Add tests for check that attributes render correctly - Document new functionality in README.njk - Generate an updated README.md file
- Allow HTML atrributes to be added to header navigation links in the Nunjucks macro template - Add tests to check that attributes render correctly - Document new functionality in README.njk - Generate an updated README.md file
kr8n3r
force-pushed
the
allow-attributes-on-child-items
branch
from
31aa3b6
to
49dac1f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-993
NickColley
approved these changes
Sep 12, 2018
added 4 commits
September 13, 2018 09:24
- Allow HTML atrributes to be added to tabs links and tabs panels in the Nunjucks macro template - Add tests to check that attributes render correctly - Document new functionality in README.njk - Generate an updated README.md file
- Allow HTML atrributes to be added to error-summary links in the Nunjucks macro template - Add tests for check that attributes render correctly - Document new functionality in README.njk - Generate an updated README.md file
- Allow HTML atrributes to be added to footer navigation and meta links
in the Nunjucks macro template
- Add tests to check that attributes render correctly
- Document new functionality in README.njk
- Generate an updated README.md file
kr8n3r
force-pushed
the
allow-attributes-on-child-items
branch
from
49dac1f
to
ae9bfd2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been requested though support and in our own work on the Prototype Kit.
Allow attributes to be added with Nunjucks macros to:
For each of the components the work includes
Trello ticket: https://trello.com/c/9BPK4u7M/414-1-allow-attributes-to-be-specified-on-items-using-macro
Fixes: #904