Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend header navigation items properties to allow for data- attributes on items in a macro #904

Closed
kr8n3r opened this issue Jul 16, 2018 · 3 comments
Closed

Extend header navigation items properties to allow for data- attributes on items in a macro #904

kr8n3r opened this issue Jul 16, 2018 · 3 comments
Labels
feature request User requests a new feature

Comments

@kr8n3r
Copy link

kr8n3r commented Jul 16, 2018

I have a need to add data- attributes to header navigation items.
We currently use a header macro, which unfortunately does not allow data- attributes on navigation items.

Consider allow that. Fallback is not to use the macro to generate the header, just use HTML.
@NickColley
Copy link
Contributor

Could this mean adding 'attributes' property support for the individual items?

@NickColley NickColley added the feature request User requests a new feature label Jul 16, 2018
@kr8n3r
Copy link
Author

kr8n3r commented Jul 16, 2018

yeah ! :)

@NickColley
Copy link
Contributor

Original alphagov/govuk-prototype-kit#551 need

@kr8n3r kr8n3r mentioned this issue Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request User requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickColley @kr8n3r