Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.1.0 #1011

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Release v2.1.0 #1011

merged 1 commit into from
Sep 26, 2018

Conversation

kr8n3r
Copy link

@kr8n3r kr8n3r commented Sep 26, 2018

2.1.0 (Feature release)

🆕 New features:

  • Allow additional 'meta' content in the footer

    You can now pass additional 'meta' content (as meta.html or meta.text) which will appear below any meta links, above the OGL license. This is ideal for, for example, the 'Built by Department Name' colophon.

    (PR #990)

  • Allow attributes to be added to some child items in header, footer, breadcrumbs, tabs and error-summary components

    You can now pass additional attributes to links in header, footer, breadcrumbs, tabs and error-summary components

    (PR #993)

  • Fix issue with conditional form content and inline form controls

    When inline variant of form controls is used with conditional content, we force it to display block.
    This is to avoid breaking and confusing styling as it is a combination we don't recommend.

    (PR #970)

  • Add component options (arguments) as macro-options.json to package

    We want to be able to expose these options to GOV.UK Design System. This change includes them as yaml in src/components and adds a build step to transform them to JSON and copy them to package/components. It also adds a test to check if the copied files are valid JSON and contain expected attributes.

    (PR #998)

🔧 Fixes:

  • Fix mobile menu button submitting parent forms

    The menu <button> didn’t have an explicit type set, which meant that it
    defaulted to type=“submit”.

    This meant that if the header was inside a form (as it is in the Design System examples, but we can imagine other scenarios where this would be the case) clicking the menu button would submit the form.

    In most cases this would also cause the page to reload, which closes the menu.

    (PR #994)

  • Fix flash of unstyled content in tabs component

    (PR #1000)

  • Add 48px favicon

    Microsoft recommends including at least a 48x48px favicon.

    (PR #986)

  • Update browsersList in package.json to reflect our supported browsers

    browsersList is used by PostCSS in our current build to determine which browser prefixes or rules to generate for the built CSS files. This PR adds rules to specify that the browsers in our browser matrix should always be prefixed for. Additionally, any browser with more than 0.1% of the global market share is prefixed for.

    In terms of changes to our built CSS, this means that -webkit-box-sizing and -webkit-box-shadow prefixes will be removed - neither of these prefixes are required by desktop Safari 5.1 or later so this seems a fairly safe change to make.

    (PR #1002)

Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Also linked the Design System to use the new package and that worked well.

@kr8n3r kr8n3r merged commit 722e069 into master Sep 26, 2018
@kr8n3r kr8n3r deleted the release-2.1.0 branch September 26, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants