Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pageStart block from template #765

Merged
merged 2 commits into from
Jun 5, 2018

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Jun 5, 2018

Closes #751

This feature can result in failures in older IE8, so it doesnt seem worth having in the public API.

IE8

Before

screen shot 2018-06-05 at 15 42 20

After

screen shot 2018-06-05 at 15 39 34

This feature can result in failures in older IE8, so it doesnt seem worth having in the public API.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-review-pr-765 June 5, 2018 14:43 Inactive
Copy link

@kr8n3r kr8n3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to remove it from the file in package/, but it's fine

@NickColley NickColley merged commit be0f7f4 into master Jun 5, 2018
@NickColley NickColley deleted the remove-template-pageStart-block branch June 5, 2018 16:06
@hannalaakso hannalaakso mentioned this pull request Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants