Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pageStart block from template #765

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Remove pageStart block from template #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c00c519
Remove pageStart block from template
NickColley Jun 5, 2018
2fbc068
Update CHANGELOG
NickColley Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ Note: We're not following semantic versioning yet, we are going to talk about th

([PR #748](https://github.com/alphagov/govuk-frontend/pull/748))

- Remove `pageStart` block from template, as could result in rendering issues in older IE.
([PR #765](https://github.com/alphagov/govuk-frontend/pull/765))

🔧 Fixes:

Expand Down
1 change: 0 additions & 1 deletion app/__tests__/app.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ describe('frontend app', () => {
})
})
;[
'pageStart',
'headIcons',
'bodyStart',
'main',
Expand Down
7 changes: 0 additions & 7 deletions app/views/examples/template-block-areas/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,6 @@

{% block bodyStart -%}
{# Since we can't show the blocks in the `<head>`, we pretend by creating a section in `bodyStart` #}
<div data-block="pageTop">
<p class="govuk-body">
Set this block for comments above the <code>&lt;!DOCTYPE html&gt;</code>, useful if you want to set a comment.
<br>
For example: <code>&lt;!-- Hello, World. --&gt;</code>
</p>
</div>
<div data-block="headIcons">
<p class="govuk-body">
Set this block to override the default icons used for GOV.UK branded pages.
Expand Down
4 changes: 0 additions & 4 deletions app/views/examples/template-custom/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@

{% extends "template.njk" %}

{% block pageStart %}
<!-- block:pageStart -->
{% endblock %}

{% set htmlClasses = 'app-html-class' %}
{% set htmlLang = 'fr' %}
{% set assetPath = '' %}
Expand Down
2 changes: 0 additions & 2 deletions package/template.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{% from "./components/skip-link/macro.njk" import govukSkipLink %}
{% from "./components/header/macro.njk" import govukHeader %}
{% from "./components/footer/macro.njk" import govukFooter %}

{% block pageStart %}{% endblock %}
<!DOCTYPE html>
<html lang="{{ htmlLang | default('en') }}" class="govuk-template {{ htmlClasses }}">
<head>
Expand Down
2 changes: 0 additions & 2 deletions src/template.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{% from "./components/skip-link/macro.njk" import govukSkipLink %}
{% from "./components/header/macro.njk" import govukHeader %}
{% from "./components/footer/macro.njk" import govukFooter %}

{% block pageStart %}{% endblock %}
<!DOCTYPE html>
<html lang="{{ htmlLang | default('en') }}" class="govuk-template {{ htmlClasses }}">
<head>
Expand Down